Refactor supported routes fetching #2875
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for wormhole-connect pending review.Visit the deploys page to approve it
|
👷 Deploy request for wormhole-connect-mainnet pending review.Visit the deploys page to approve it
|
artursapek
commented
Oct 24, 2024
|
|
||
| const { token, destToken, fromChain, toChain, amount } = useSelector( | ||
| (state: RootState) => state.transferInput, | ||
| ); | ||
|
|
||
| const { toNativeToken } = useSelector((state: RootState) => state.relay); | ||
|
|
||
| const [debouncedAmount] = useDebounce(amount, 500); |
There was a problem hiding this comment.
this debounce is redundant with another one in AmountInput. causes unneeded delay.
emreboga
reviewed
Oct 24, 2024
| @@ -165,7 +131,7 @@ const Routes = ({ ...props }: Props) => { | |||
| {props.isLoading && renderRoutes.length === 0 ? ( | |||
| <Skeleton variant="rounded" height={153} width="100%" /> | |||
There was a problem hiding this comment.
Nitpick: Instead of one empty skeleton, do you think we can have two small horizontal ones at the top and a bigger one below those, to imitate this look:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves the "supported routes" list out of Redux, because the only place we really need it is the
useSupportedRoutesWithQuoteshook. It is now fetched in there and pipelined into the downstream quotes call.Here is a loom demonstrating the reason I made this change in the first place... it improves how the UI transitions through the loading state:
https://www.loom.com/share/5aab31c51e8346e09bd533d05ffde5e5